Wan support to skip compilation by tv-karthikeya · Pull Request #734 · quic/efficient-transformers

tv-karthikeya · 2026-01-18T12:26:51Z

Support to skip export, compilation if qpc already exists

Updated Flux, wan configs, pipelines with qpc_path changes

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

- Updated export dim from 180p to 90p for wan - Updated flux, wan configs Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj · 2026-01-19T14:09:37Z

QEfficient/diffusers/pipelines/flux/pipeline_flux.py

@@ -304,9 +305,6 @@ def compile(
        ):
            self.export(use_onnx_subfunctions=use_onnx_subfunctions)



How it will deal with the config file I will share with direct compile call?

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj · 2026-01-20T05:54:49Z

QEfficient/diffusers/pipelines/wan/pipeline_wan.py

        custom_config_path: Optional[str] = None,
        use_onnx_subfunctions: bool = False,
        parallel_compile: bool = True,
+        skip_compile: bool = False,


quic-amitraj · 2026-01-20T05:58:38Z

QEfficient/diffusers/pipelines/pipeline_utils.py



-def set_module_device_ids(cls):
+def set_module_device_ids_and_qpc_paths(cls):


Could you please rename this to set_execute_params? This name became so long and generic name gives us more flexiblity to add params in later stage.

quic-amitraj · 2026-01-20T06:01:21Z

QEfficient/diffusers/pipelines/pipeline_module.py

        latent_frames = constants.WAN_ONNX_EXPORT_LATENT_FRAMES
-        latent_height = constants.WAN_ONNX_EXPORT_LATENT_HEIGHT_180P
-        latent_width = constants.WAN_ONNX_EXPORT_LATENT_WIDTH_180P
+        latent_height = constants.WAN_ONNX_EXPORT_LATENT_HEIGHT_90P


Why these changes? Any sepcific reason

quic-amitraj · 2026-01-20T06:01:39Z

QEfficient/diffusers/pipelines/pipeline_module.py

                4: "latent_width",
            },
-            "timestep": {0: "steps"},
            "encoder_hidden_states": {0: "batch_size", 1: "sequence_length"},


quic-amitraj · 2026-01-20T06:05:09Z

QEfficient/utils/constants.py

-WAN_ONNX_EXPORT_HEIGHT_180P = 192
-WAN_ONNX_EXPORT_WIDTH_180P = 320
+# Wan dims for 90p
+WAN_ONNX_EXPORT_CL_90P = 960  # for 16 latent frames


Why these changes in this PR?

quic-amitraj · 2026-01-20T06:06:48Z

examples/diffusers/wan/wan_lightning.py

    num_inference_steps=4,
    generator=torch.manual_seed(0),
-    custom_config_path="examples/diffusers/wan/wan_config.json",
    height=480,


why removed?

tv-karthikeya · 2026-01-20T07:48:15Z

Reverted the changes done for 90p onnx export

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj

Lets address these minor comments, and merge this on priority.

quic-amitraj · 2026-01-20T08:05:39Z

QEfficient/diffusers/pipelines/flux/pipeline_flux.py

+        # Load compilation configuration
+        config_manager(self, config_source=compile_config, use_onnx_subfunctions=use_onnx_subfunctions)
+
+        # Set device IDs for all modules based on configuration


Update the comment as well.

quic-amitraj · 2026-01-20T08:10:40Z

QEfficient/diffusers/pipelines/pipeline_utils.py

+        module_obj.qpc_path = config_modules[module_name]["execute"]["qpc_path"]
+        if module_obj.qpc_path:
+            if not os.path.exists(module_obj.qpc_path):
+                logger.warning(
+                    f"Given qpc path: {module_obj.qpc_path} does not exist, considering {module_name} for compilation"
+                )
+                module_obj.qpc_path = None


We should throw error if qpc path is not correct.

quic-amitraj · 2026-01-20T08:12:55Z

examples/diffusers/wan/wan_lightning_custom.py

+# When to use:
+# - When you want to skip export, compile if you already had compiled qpc


Update this line with this-> Use this when you want to skip export and compilation if you have already compiled QPC.

quic-amitraj · 2026-01-20T08:13:46Z

examples/diffusers/wan/wan_lightning_custom.py

+# When to use:
+# - When you want to skip export, compile if you already had compiled qpc
+#
+# Changes needed in config.json: update qpc_path for each module


update qpc_path of desired module

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj

LGTM

- added num layers fix - updated wan example script Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Support to skip export, compilation if qpc already exists - Updated Flux, wan configs, pipelines with qpc_path changes --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> (cherry picked from commit b777e8b)

Support to skip export, compilation if qpc already exists - Updated Flux, wan configs, pipelines with qpc_path changes --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Support to skip export, compilation if qpc already exists - Updated Flux, wan configs, pipelines with qpc_path changes --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>

Support to skip export, compilation if qpc already exists - Updated Flux, wan configs, pipelines with qpc_path changes --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

tv-karthikeya added 2 commits January 16, 2026 14:19

Quick fix to skip compilation

d856874

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Support to skip compilation for diffusers

12fbac7

- Updated export dim from 180p to 90p for wan - Updated flux, wan configs Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

tv-karthikeya force-pushed the wan_skip_compile branch from fe02ec8 to 12fbac7 Compare January 18, 2026 12:32

tv-karthikeya marked this pull request as ready for review January 18, 2026 12:43

tv-karthikeya requested review from ochougul, quic-amitraj, quic-hemagnih and quic-rishinr as code owners January 18, 2026 12:43

Updated Pytests to call config manager before compilation

973c2b0

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

tv-karthikeya force-pushed the wan_skip_compile branch from c5b0424 to 973c2b0 Compare January 19, 2026 07:53

quic-amitraj requested changes Jan 19, 2026

View reviewed changes

tv-karthikeya added 2 commits January 19, 2026 15:40

Updating Compile Api

332e242

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Reverting 2 layer change

d25f18a

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj requested changes Jan 20, 2026

View reviewed changes

tv-karthikeya force-pushed the wan_skip_compile branch from 97caf8b to 811b0fe Compare January 20, 2026 07:45

tv-karthikeya force-pushed the wan_skip_compile branch from 811b0fe to 7684bf5 Compare January 20, 2026 07:50

Reverting export 90p changes

2ec739a

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

tv-karthikeya force-pushed the wan_skip_compile branch from 7684bf5 to 2ec739a Compare January 20, 2026 07:52

quic-amitraj requested changes Jan 20, 2026

View reviewed changes

Exit on qpc path does not exist, minor changes

c4cd9cf

Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

quic-amitraj approved these changes Jan 20, 2026

View reviewed changes

tv-karthikeya added 3 commits January 20, 2026 14:42

Merge branch 'main' into wan_skip_compile

8d518b1

Merge branch 'main' into wan_skip_compile

bcfdaa1

Merge branch 'quic:main' into wan_skip_compile

71d1c93

tv-karthikeya force-pushed the wan_skip_compile branch 2 times, most recently from bde6882 to 71d1c93 Compare January 27, 2026 17:39

tv-karthikeya added 2 commits January 28, 2026 03:23

Minor bug fixes

9a6ba22

- added num layers fix - updated wan example script Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>

Merge branch 'main' into wan_skip_compile

79d347e

vbaddi assigned tv-karthikeya Jan 28, 2026

vbaddi approved these changes Jan 28, 2026

View reviewed changes

quic-amitraj merged commit b777e8b into quic:main Jan 28, 2026
4 checks passed

		@@ -304,9 +305,6 @@ def compile(
		):
		self.export(use_onnx_subfunctions=use_onnx_subfunctions)



		def set_module_device_ids(cls):
		def set_module_device_ids_and_qpc_paths(cls):

		# When to use:
		# - When you want to skip export, compile if you already had compiled qpc

Conversation

tv-karthikeya commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tv-karthikeya commented Jan 20, 2026

Uh oh!

quic-amitraj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quic-amitraj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments