Add support for num_crops and valid_size from vLLM#796
Merged
Conversation
quic-vargupt
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-vargupt
force-pushed
the
molmo_vllm_epd_fix
branch
from
88cdf14 to
f6281ca
Compare
quic-rishinr
force-pushed
the
molmo_vllm_epd_fix
branch
from
f6281ca to
d3e09cc
Compare
Contributor
|
@quic-vargupt Can you please fix the LINT errors. |
quic-rishinr
requested review from
mohiso22 and
quic-dhirajku
and removed request for
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
Contributor
|
@mohiso22 @quic-dhirajku please review the PR |
mohiso22
approved these changes
Apr 24, 2026
quic-rishinr
force-pushed
the
molmo_vllm_epd_fix
branch
from
d3e09cc to
fb2a130
Compare
Contributor
|
@quic-vargupt please fix the lint issue |
quic-rishinr
force-pushed
the
molmo_vllm_epd_fix
branch
2 times, most recently
from
914761e to
af6a2c4
Compare
Contributor
|
LINT to be fixed, |
Contributor
|
@quic-vargupt please fix the LINT errors |
quic-rishinr
force-pushed
the
molmo_vllm_epd_fix
branch
from
af6a2c4 to
159e539
Compare
Signed-off-by: Varun Gupta <vargupt@qti.qualcomm.com>
quic-rishinr
force-pushed
the
molmo_vllm_epd_fix
branch
from
23310ac to
5169953
Compare
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
May 19, 2026
The following PR add support for `num_crops` and `valid_size` from vLLM in override configs in case of E-PD. --------- Signed-off-by: Varun Gupta <vargupt@qti.qualcomm.com> Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Co-authored-by: Rishin Raj <rishinr@qti.qualcomm.com>
quic-mohmeh
pushed a commit
to quic-mohmeh/efficient-transformers
that referenced
this pull request
May 25, 2026
The following PR add support for `num_crops` and `valid_size` from vLLM in override configs in case of E-PD. --------- Signed-off-by: Varun Gupta <vargupt@qti.qualcomm.com> Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Co-authored-by: Rishin Raj <rishinr@qti.qualcomm.com> Signed-off-by: Mohit Mehta <mohmeh@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
May 25, 2026
The following PR add support for `num_crops` and `valid_size` from vLLM in override configs in case of E-PD. --------- Signed-off-by: Varun Gupta <vargupt@qti.qualcomm.com> Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Co-authored-by: Rishin Raj <rishinr@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR add support for
num_cropsandvalid_sizefrom vLLM in override configs in case of E-PD.