Updated the ROPE dtype for custom_dtype#989
Merged
Merged
Conversation
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
asmigosw
requested review from
quic-hemagnih and
quic-rishinr
and removed request for
quic-rishinr
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
quic-hemagnih
requested changes
May 18, 2026
Contributor
quic-hemagnih
left a comment
quic-hemagnih
left a comment
There was a problem hiding this comment.
@asmigosw I think the medium severity comments posted by Qgenie are valid and are edge/negative case handling which is a good coding practise.
Can you please incorporate both of them in your code.
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
quic-hemagnih
approved these changes
May 18, 2026
Contributor
quic-hemagnih
left a comment
quic-hemagnih
left a comment
There was a problem hiding this comment.
LGTM, lets merge once CI is passed
quic-mohmeh
pushed a commit
to quic-mohmeh/efficient-transformers
that referenced
this pull request
May 25, 2026
ROPE dtype was set to torch.get_default_dtype() which was float32 by default. Changed it to set the config's dtype which was set by user. --------- Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com> Signed-off-by: Mohit Mehta <mohmeh@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
May 25, 2026
ROPE dtype was set to torch.get_default_dtype() which was float32 by default. Changed it to set the config's dtype which was set by user. --------- Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROPE dtype was set to torch.get_default_dtype() which was float32 by default. Changed it to set the config's dtype which was set by user.