Subfunction changes qwen2 5#999
Merged
quic-rishinr merged 4 commits intoMay 22, 2026
Merged
Conversation
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
quic-mohmeh
pushed a commit
to quic-mohmeh/efficient-transformers
that referenced
this pull request
May 25, 2026
## Performance Note When compiling the Qwen2.5 vision encoder with subfunctions enabled, a performance degradation is observed. This is primarily due to a computation within the VisionAttention module that remains invariant across layers, resulting in unnecessary repeated execution and increased runtime overhead. --------- Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Signed-off-by: Mohit Mehta <mohmeh@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
May 25, 2026
When compiling the Qwen2.5 vision encoder with subfunctions enabled, a performance degradation is observed. This is primarily due to a computation within the VisionAttention module that remains invariant across layers, resulting in unnecessary repeated execution and increased runtime overhead. --------- Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Note
When compiling the Qwen2.5 vision encoder with subfunctions enabled, a performance degradation is observed. This is primarily due to a computation within the VisionAttention module that remains invariant across layers, resulting in unnecessary repeated execution and increased runtime overhead.