fix(frontend): Version state not updating after auto-update restart

[sagarsrc]

Bug Description

After clicking "Update" and server successfully restarts with new version, the frontend notification still shows the old version (e.g., "v0.2.1 → v0.2.2") instead of either:

1. Showing "Updated to v0.2.2!" toast
2. Hiding the notification (since update_available is now false)

Steps to Reproduce

1. Install older version: uvx quickcall-supertrace@0.2.1
2. Open UI - see update notification "v0.2.1 → v0.2.2"
3. Click "Update" button
4. Wait for "Installing..." → "Restarting..." states
5. Server comes back (verified via curl /api/version returns 0.2.2)
6. Bug: Notification still shows "v0.2.1 → v0.2.2"
7. Manual page refresh fixes it (notification disappears)

Expected Behavior

After server comes back:

1. Show "Updated to v0.2.2!" toast for 5 seconds
2. checkVersion() runs and updates versionInfo state
3. Notification hides (since update_available: false)

Actual Behavior

• "Restarting..." state clears but old version info remains displayed
• checkVersion() either doesn't run or state doesn't update
• Requires manual refresh to see correct state

Technical Details

File: packages/web/src/hooks/useVersionCheck.ts

The issue is in pollHealth function (lines 106-129):

if (healthResponse.ok) {
  setUpdateState({ status: 'idle', message: `Updated to v${data.new_version}!` });
  await checkVersion();  // <-- This should update versionInfo state
  // ...
}

Possible causes:

• Race condition between state updates
• checkVersion() failing silently
• React state not triggering re-render

Environment

• Version: 0.2.1 → 0.2.2
• Install method: uvx
• Browser: (any)

[sagarsrc]

Fixed. The issue was checkVersion() immediately resetting updateState to {status: 'checking', message: null}, overwriting the success message.

Solution: Fetch version info directly in pollHealth without calling checkVersion(), then set the success message after.

[sagarsrc]

Bug Not Fixed - Root Cause Found

The fix in v0.2.3 didn't resolve the issue. The success toast still doesn't show.

Root Cause

In UpdateNotification.tsx, the success toast check comes after the early return:

// Line 21-37: Early return if no update
if (!versionInfo?.updateAvailable || isDismissed) {
  if (updateState.status !== 'updating' && updateState.status !== 'restarting') {
    return null;  // ← HIDES before reaching success toast!
  }
}

// Line 41-50: Success toast (never reached when updateAvailable=false)
if (updateState.status === 'idle' && updateState.message) {
  return <SuccessToast />;
}

What happens:

1. Server restarts to v0.2.3
2. setVersionInfo({ updateAvailable: false, ... }) runs
3. setUpdateState({ status: 'idle', message: 'Updated to v0.2.3!' }) runs
4. Component re-renders: updateAvailable=false + status=idle → early return → hides
5. Success toast block never reached

Fix

Move the success toast check before the early return:

// Show success toast even if no update available (just updated!)
if (updateState.status === 'idle' && updateState.message) {
  return (
    <div className="fixed bottom-4 left-4 z-50">
      <div className="bg-primary text-primary-foreground rounded-lg shadow-lg px-3 py-2 text-sm flex items-center gap-2">
        <i className="ri-check-line" />
        {updateState.message}
      </div>
    </div>
  );
}

// Then early return if no update
if (!versionInfo?.updateAvailable || isDismissed) {
  // ...
}

[sagarsrc]

Testing Flow

Setup

uv cache clean quickcall-supertrace
uvx quickcall-supertrace@0.2.2   # or any older version

Expected Flow

1. Open UI → Update notification appears: "v0.2.2 → v0.2.3"

2. Click Update → Button shows "Installing..." spinner

3. Terminal → Original server process exits:

   INFO: Shutting down
   INFO: Application shutdown complete.
   

4. UI → Shows "Restarting..." spinner

5. Background → New server process spawns with latest version:

   INFO: Started server process [xxxxx]
   INFO: Application startup complete.
   

6. Verify (in separate terminal):

   curl -s http://localhost:7845/api/version | jq
   # Should show: "current_version": "0.2.3"

7. UI → "Restarting..." spinner stops

8. UI → ✅ Success toast: "Updated to v0.2.3!" ← THIS IS NOT SHOWING

9. UI → Notification disappears (no update available)

Current Behavior

Steps 1-7 work correctly. Step 8 fails - the success toast never appears. User must manually refresh to see the updated version.

[sagarsrc]

Fixed. Moved success toast check BEFORE the early return that checks updateAvailable. Now the toast displays even when updateAvailable is false after the update completes.