Skip to content

Validate sequence number in nextReject()#1236

Merged
chrjohn merged 2 commits into
masterfrom
chrjohn-patch-1
May 22, 2026
Merged

Validate sequence number in nextReject()#1236
chrjohn merged 2 commits into
masterfrom
chrjohn-patch-1

Conversation

@chrjohn
Copy link
Copy Markdown
Member

@chrjohn chrjohn commented May 21, 2026

Fixes #1235

@chrjohn chrjohn changed the title Validate seqnum in nextReject method Validate seqnum in nextReject() May 22, 2026
@chrjohn chrjohn changed the title Validate seqnum in nextReject() Validate sequence number in nextReject() May 22, 2026
@chrjohn chrjohn added this to the QFJ 3.0.2 milestone May 22, 2026
@chrjohn
Copy link
Copy Markdown
Member Author

chrjohn commented May 22, 2026

@copilot please create a unit test that ensures that sequence numbers are always validated when receiving a Reject message. Test different scenarios (too high, too low) and check that the expected sequence number is incremented when it is the expected sequence number.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

@copilot please create a unit test that ensures that sequence numbers are always validated when receiving a Reject message. Test different scenarios (too high, too low) and check that the expected seq...

Added and pushed a focused unit test update in SessionTest to explicitly cover Reject MsgSeqNum scenarios in this order: too high, too low, and expected value; it verifies target sequence number does not increment for high/low and does increment for the expected sequence. Commit: db22a94.

@chrjohn chrjohn merged commit 9c1edb2 into master May 22, 2026
21 checks passed
@chrjohn chrjohn deleted the chrjohn-patch-1 branch May 22, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too high sequence numbers for Reject messages are not verified

2 participants