Skip to content

Conversation

@dparui
Copy link
Contributor

@dparui dparui commented Sep 23, 2020

Fixes #314

ResetOnLogon/ResetOnLogout/ResetOnDisconnect fails when PersistMessages is set to 'N'. It throws an IOException "Invalid object name messages"

More details at #314

@chrjohn chrjohn changed the title #314: ResetOnLogon/ResetOnLogout/ResetOnDisconnect fails when PersistMessages is set to 'N' ResetOnLogon/ResetOnLogout/ResetOnDisconnect fails when PersistMessages is set to 'N' Sep 24, 2020
@chrjohn chrjohn added the please review asking for a review label Oct 19, 2020
@chrjohn chrjohn removed the please review asking for a review label Sep 6, 2021
@chrjohn
Copy link
Member

chrjohn commented Sep 6, 2021

I thought about this. IMHO there are quite some changes to solve a problem in only one of the stores In my opinion it would be easier to query the PersistMessages setting in the JdbcStore and then try to delete the messages table based on that setting.
What do you think?

@dparui
Copy link
Contributor Author

dparui commented Sep 6, 2021

Restricted changes to JdbcStore as suggested. Please review.

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Sep 24, 2021
@chrjohn chrjohn merged commit 7ca1cb5 into quickfix-j:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResetOnLogon/ResetOnLogout/ResetOnDisconnect fails when PersistMessages is set to 'N'

2 participants