Skip to content

Conversation

@leonchen83
Copy link
Contributor

@leonchen83 leonchen83 commented Aug 4, 2022

Signed-off-by: Baoyi Chen chen.bao.yi@qq.com
Original PR: #456

@chrjohn
Copy link
Member

chrjohn commented Aug 24, 2022

@leonchen83
Could you remove the leap second fix from this PR and open a separate with the changes from this (i.e. #529) PR plus the leap second fix against master?
Or alternatively open another PR only with the optimization but without the leap second fix against master.
Thank you.

Signed-off-by: Baoyi Chen <chen.bao.yi@qq.com>
@leonchen83
Copy link
Contributor Author

sorry reply late. I rollbacked leap second code. please merge this PR first

@chrjohn chrjohn changed the title Optimize convertToLocalDateTime method Optimize convertToLocalDateTime method Aug 25, 2022
Signed-off-by: Baoyi Chen <chen.bao.yi@qq.com>
@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Sep 9, 2022
@chrjohn chrjohn merged commit 0b60ffe into quickfix-j:master Sep 9, 2022
@chrjohn
Copy link
Member

chrjohn commented Sep 9, 2022

Hi @leonchen83 ,
thanks for the PR. I have just merged it. Before you create a PR for the leap second stuff, please wait until further notice. I need to clean something up first.
Cheers,
Chris.

Dmitriy-Yugay pushed a commit to Dmitriy-Yugay/quickfixj that referenced this pull request Nov 21, 2022
* Optimize convertToLocalDateTime method
* Optimize try catch block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants