Skip to content

Optimize convertToLocalDateTime method #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Optimize convertToLocalDateTime method #529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a343a2
Optimize convertToLocalDateTime method
leonchen83 Aug 4, 2022
301e2d9
Optimize try catch block
leonchen83 Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions quickfixj-core/src/main/java/quickfix/field/converter/UtcTimestampConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
import quickfix.SystemTime;

import java.text.DateFormat;
import java.time.DateTimeException;
import java.time.LocalDateTime;
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeParseException;
import java.util.Calendar;
import java.util.Date;
import java.util.GregorianCalendar;
Expand Down Expand Up @@ -136,25 +136,36 @@ public static Date convert(String value) throws FieldConvertError {
public static LocalDateTime convertToLocalDateTime(String value) throws FieldConvertError {
verifyFormat(value);
int length = value.length();
int ns = 0;
if (length >= LENGTH_INCL_NANOS) {
ns = parseInt(value, 18, 9);
} else if (length == LENGTH_INCL_MICROS) {
ns = parseInt(value, 18, 6) * 1000;
} else if (length == LENGTH_INCL_MILLIS) {
ns = parseInt(value, 18, 3) * 1000000;
}

int yy = parseInt(value, 0, 4);
int mm = parseInt(value, 4, 2);
int dd = parseInt(value, 6, 2);
int h = parseInt(value, 9, 2);
int m = parseInt(value, 12, 2);
int s = parseInt(value, 15, 2);
try {
switch (length) {
case LENGTH_INCL_SECONDS:
return LocalDateTime.parse(value, FORMATTER_SECONDS);
case LENGTH_INCL_MILLIS:
return LocalDateTime.parse(value, FORMATTER_MILLIS);
case LENGTH_INCL_MICROS:
return LocalDateTime.parse(value, FORMATTER_MICROS);
case LENGTH_INCL_NANOS:
case LENGTH_INCL_PICOS:
return LocalDateTime.parse(value.substring(0, LENGTH_INCL_NANOS), FORMATTER_NANOS);
default:
throwFieldConvertError(value, TYPE);
}
} catch (DateTimeParseException e) {
return LocalDateTime.of(yy, mm, dd, h, m, s, ns);
} catch (DateTimeException e) {
throwFieldConvertError(value, TYPE);
}
return null;
}
}

private static int parseInt(String value, int off, int len) {
int num = 0;
for (int index = 0; index < len; index++) {
num = (num * 10) + value.charAt(off + index) - '0';
}
return num;
}

private static Long getMillisForDay(String value) {
// Performance optimization: the calendar for the start of the day is cached.
Expand Down