Replace pthreads with C11 threading support#10
Closed
bnoordhuis wants to merge 2 commits into
Closed
Conversation
This should make it feasible to build quickjs on Windows with VS 2022. Fixes: quickjs-ng#1
Contributor
Author
|
Jezus, it's 2023 and Apple still doesn't support |
Contributor
Author
|
The copy of VS on GHA isn't new enough either 🤦 |
Contributor
|
😭😭😭 |
Contributor
|
Hi, I would love to get msvc support. It seems there has been some work in the past: bellard/quickjs#49. Not a simple patch to maintain but probably worth it? |
Contributor
|
It's on our roadmap yes. |
dblnz
pushed a commit
to dblnz/quickjs
that referenced
this pull request
May 6, 2026
… warning (quickjs-ng#10) Agent-Logs-Url: https://github.com/G-Yong/quickjs/sessions/d47f1173-4bb5-49cb-895c-0ee2e898fddc Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: G-Yong <21030893+G-Yong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it feasible to build quickjs on Windows with VS 2022.
Fixes: #1