Skip to content

Fix Array.fromAsync function prototype #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Fix Array.fromAsync function prototype #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7495,6 +7495,11 @@ static JSValue js_bytecode_autoinit(JSContext *ctx, JSObject *p, JSAtom atom,
for (size_t i = 0; i < countof(args); i++)
JS_FreeValue(ctx, args[i]);
JS_FreeValue(ctx, fun);
if (JS_SetPrototypeInternal(ctx, result, ctx->function_proto,
/*throw_flag*/true) < 0) {
JS_FreeValue(ctx, result);
return JS_EXCEPTION;
}
return result;
}
}
Expand Down
6 changes: 0 additions & 6 deletions test262_errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
test262/test/built-ins/Array/fromAsync/builtin.js:24: Test262Error: Prototype of Array.fromAsync is Function.prototype Expected SameValue(«[object AsyncFunction]», «function () {
[native code]
}») to be true
test262/test/built-ins/Array/fromAsync/builtin.js:24: strict mode: Test262Error: Prototype of Array.fromAsync is Function.prototype Expected SameValue(«[object AsyncFunction]», «function () {
[native code]
}») to be true
test262/test/built-ins/AsyncFromSyncIteratorPrototype/next/iterator-result-poisoned-wrapper.js:64: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/next/iterator-result-poisoned-wrapper.js:64: strict mode: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/next/next-result-poisoned-wrapper.js:69: TypeError: $DONE() not called
Expand Down