GNU/Hurd build fixes #1092
Merged
GNU/Hurd build fixes #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malloc_usable_size() is a GNU extension in GNU libc; hence, use it every time GNU libc is used, rather than only on Linux. Cherry-pick of bellard/quickjs@3489493.
Strictly speaking, they are available in POSIX.1-2008 [1][2], so they could be used on more platforms/OSes. To be cautious, enable them when using GNU libc, since they have been available with that libc for a very long time. Cherry-pick of bellard/quickjs@8624b5c. [1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html [2] https://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html
PATH_MAX is optional in POSIX, and it is not available on GNU/Hurd. There is already a fallback definition called JS__PATH_MAX, so switch all the common code (i.e. not the bits specific to a certain OS) to use it.
There is a Linux-like procfs that provides /proc/self/exe, so use the Linux implementation of js_exepath() also on GNU/Hurd.
This makes it possible to detect quickjs is running on GNU/Hurd.
saghul
reviewed
Jun 3, 2025
Not sure why they would.
This is exactly the opposite of what is needed for GNU/Hurd. The current Linux paths for |
saghul
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build of quickjs on GNU/Hurd:
malloc_usable_size()when using glibcftello()&fseeko()when using glibc (they could be used more, I took a conservative approach)JS__PATH_MAXinstead ofPATH_MAXin common codeos.exePathos.platformashurdSee the messages of the various commits for longer explanations.
A couple of changes are cherry-picked (with the needed changes) from bellard/quickjs#316.