Make JSString smaller #1252
Merged
Make JSString smaller #1252
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC apparently doesn't merge adjacent bit fields if they don't have the same type. Change the uint8_t fields to uint32_t. It was reported that `sizeof(JSString)` was 48 bytes on Windows but it should be 40 bytes now, like it is on x86_64 Linux. Fixes: quickjs-ng#1250
saghul
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC apparently doesn't merge adjacent bit fields if they don't have the same type. Change the uint8_t fields to uint32_t.
It was reported that
sizeof(JSString)was 48 bytes on Windows but it should be 40 bytes now, like it is on x86_64 Linux.Fixes: #1250