Implement explicit resource management#1458
Conversation
42bc792 to
4fdbe0e
Compare
bnoordhuis
left a comment
There was a problem hiding this comment.
+1700 lines is more than I have time to review in-depth at the moment. I'll trust your good judgement.
|
Could you please share some good merged PR or a commit with similar stuff added to compare for better understanding ? ❤️ |
|
Not sure what you mean, can you rephrase? This is the implementation itself, there is no other. Ben made an inception PR but it didn't include the new syntax. This PR implements the entire spec. |
I mean not about this exact spec, but another apriori well implemented. for keywords
|
That is generated bytecode that we embed in the engine and or CLI. Some builtins are written in JS, and we generate the bytecode and embed it. Likewise, for the CLI, the REPL is written is JS and is embedded the same way.
That is how the original project was writtern and after some debate (you can search around the old isses) we decided to keep it. Personally, I didn't like it at first but I don't mind it anymore :-) |
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> Closes: #865
4fdbe0e to
9ec1734
Compare
Co-authored-by: Ben Noordhuis info@bnoordhuis.nl
Closes: #865