Skip to content

fix(cmake): avoid qjs/qjs_exe PDB filename collision on Windows parallel builds#1474

Merged
saghul merged 1 commit into
quickjs-ng:masterfrom
mvanhorn:fix/1241-avoid-qjs-qjs-exe-pdb-filename-collision-on-window
May 16, 2026
Merged

fix(cmake): avoid qjs/qjs_exe PDB filename collision on Windows parallel builds#1474
saghul merged 1 commit into
quickjs-ng:masterfrom
mvanhorn:fix/1241-avoid-qjs-qjs-exe-pdb-filename-collision-on-window

Conversation

@mvanhorn
Copy link
Copy Markdown
Contributor

Summary

On Windows, when qjs (the executable) and qjs_exe (the helper target) are built in parallel, both targets write to qjs.pdb and collide. The fix sets a unique PDB_NAME per target.

Why this matters

Parallel-build collisions show up as flaky CL on Windows builders. Reporter pinpointed the colliding PDB filename in build logs.

Changes

  • CMakeLists.txt - set PDB_NAME qjs for the qjs target and PDB_NAME qjs_exe for the qjs_exe target.

Fixes #1241

@saghul saghul merged commit 3da8a4a into quickjs-ng:master May 16, 2026
124 checks passed
@mvanhorn
Copy link
Copy Markdown
Contributor Author

Thanks for the quick merge, @saghul! Glad the PDB filename change cleared the Windows parallel-build collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CMake] Name conflict causes a compile error

2 participants