fix(cmake): avoid qjs/qjs_exe PDB filename collision on Windows parallel builds#1474
Merged
saghul merged 1 commit intoMay 16, 2026
Conversation
saghul
approved these changes
May 16, 2026
Contributor
Author
|
Thanks for the quick merge, @saghul! Glad the PDB filename change cleared the Windows parallel-build collision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, when
qjs(the executable) andqjs_exe(the helper target) are built in parallel, both targets write toqjs.pdband collide. The fix sets a uniquePDB_NAMEper target.Why this matters
Parallel-build collisions show up as flaky CL on Windows builders. Reporter pinpointed the colliding PDB filename in build logs.
Changes
CMakeLists.txt- setPDB_NAME qjsfor theqjstarget andPDB_NAME qjs_exefor theqjs_exetarget.Fixes #1241