Conversation
saghul
force-pushed
the
cmake
branch
7 times, most recently
from
855892b to
2459ad2
Compare
Contributor
Author
|
@bnoordhuis Can you PTAL? Here is a proposal: once CONFIG_BIGNUM is gone I'll rebase this and we can consider landing it alongside the Makefile. I know it's not feature complete yet (left a TODO note) but it would be funcional enough that projects that only care about the static library target can switch to this (like txiki.js ;-)). Then I'll work towards making it more complete and we can eventually replace the Makefile with calls to CMake. WDYT? |
bnoordhuis
approved these changes
Nov 9, 2023
Contributor
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Feel free to land, I can rip out the CONFIG_BIGNUM stuff later.
dblnz
pushed a commit
to dblnz/quickjs
that referenced
this pull request
May 6, 2026
* fix: wrap debug_trace test with #ifdef QJS_ENABLE_DEBUGGER Agent-Logs-Url: https://github.com/G-Yong/quickjs/sessions/c47f60f2-9eab-4e86-a75e-3755d5e81466 Co-authored-by: G-Yong <21030893+G-Yong@users.noreply.github.com> * chore: remove accidentally committed build-debug directory Agent-Logs-Url: https://github.com/G-Yong/quickjs/sessions/c47f60f2-9eab-4e86-a75e-3755d5e81466 Co-authored-by: G-Yong <21030893+G-Yong@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: G-Yong <21030893+G-Yong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not even functional yet, but let's get the ball rolling...