wayland: add dwl/mango support by charlesrocket · Pull Request #609 · quickshell-mirror/quickshell

charlesrocket · 2026-03-06T13:42:34Z

Tested with mango 0.12.4(release)

Merges charlesrocket's dwl branch (PR quickshell-mirror#609) with wl_proto() refactor replacing hand-rolled protocol bindings.

outfoxxed

Wayland protocols are not implemented like this in a qt project. Look at
https://github.com/quickshell-mirror/quickshell/tree/master/src/wayland/hyprland/global_shortcuts for a simple one. We also never check in generated code.

src/wayland/dwl/manager.cpp

charlesrocket · 2026-03-08T00:25:27Z

Wayland protocols are not implemented like this in a qt project. Look at https://github.com/quickshell-mirror/quickshell/tree/master/src/wayland/hyprland/global_shortcuts for a simple one. We also never check in generated code.

Oh, missed that one! It is not generated tho, just a bespoke implementation 😺

outfoxxed · 2026-03-08T00:45:38Z

I see how you could potentially miss the QtWayland tooling and qtwaylandscanner but how do you miss wayland-scanner? Nobody does that part by hand

charlesrocket · 2026-03-08T01:02:14Z

It was pretty late, and DWL spec is not long enough for me to look for easy ways ahah

outfoxxed

Partial review:

Can you clarify if tags are functionally per monitor or global? the global tagCount seems to indicate they're global, and if setting client tags via monitor affects global or monitor state?

src/wayland/dwl/CMakeLists.txt

src/wayland/dwl/dwl-ipc-unstable-v2.xml

src/wayland/dwl/manager.cpp

outfoxxed · 2026-03-08T22:11:52Z

src/wayland/dwl/output.hpp

+class DwlIpcOutput
+    : public QObject
+    , public QtWayland::zdwl_ipc_output_v2 {


Undecided on if its OK to merge the implementation and interface on this one

outfoxxed · 2026-03-08T22:14:45Z

src/wayland/dwl/output.hpp

+	/// Title of the focused window, empty if none.
+	Q_PROPERTY(QString title READ title NOTIFY titleChanged);
+	/// App ID of the focused window, empty if none.
+	Q_PROPERTY(QString appId READ appId NOTIFY appIdChanged);


Duplicates information exposed by toplevel management less usefully.

outfoxxed · 2026-03-08T22:15:49Z

src/wayland/dwl/output.hpp

+	/// Whether a client is fullscreen on this output.
+	Q_PROPERTY(bool fullscreen READ fullscreen NOTIFY fullscreenChanged);


Also duplicate

outfoxxed · 2026-03-08T22:16:32Z

src/wayland/dwl/output.hpp

+	/// Whether the focused client is floating.
+	Q_PROPERTY(bool floating READ floating NOTIFY floatingChanged);


If exposed at all this should probably be attached to toplevel

outfoxxed · 2026-03-08T22:26:14Z

Also does mango support the ext-workspace protocol? We have a mostly done implementation on a branch that I could fix up and merge, which is strictly an improvement over this protocol.

charlesrocket · 2026-03-09T00:12:47Z

Partial review:

Can you clarify if tags are functionally per monitor or global? the global tagCount seems to indicate they're global, and if setting client tags via monitor affects global or monitor state?

DWL is all per output

///! A DWL monitor/output with IPC state.
/// Exposes per-monitor compositor state: tag list, active layout, focused
/// window title, app ID, and fullscreen/floating flags.

///! State of a single DWL tag.
/// Represents one tag slot on @@DwlIpcOutput.

Tho tag count and layouts are global.

charlesrocket · 2026-03-09T00:13:52Z

Also does mango support the ext-workspace protocol? We have a mostly done implementation on a branch that I could fix up and merge, which is strictly an improvement over this protocol.

Looks like it does https://github.com/mangowm/mango/blob/d441ca22f4bd7554f04defdd36f13bedc38610e7/src/ext-protocol/ext-workspace.h

herry6548 · 2026-03-09T09:08:56Z

The upcoming release of wlroots0.20 has also integrated the encapsulation support of the ext-workspace protocol. At that time, most compositor will only need little code to use this protocol.

refer:
https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/5115

outfoxxed requested changes Mar 7, 2026

View reviewed changes

src/wayland/dwl/manager.cpp Outdated Show resolved Hide resolved

src/wayland/dwl/manager.cpp Outdated Show resolved Hide resolved

src/wayland/dwl/manager.cpp Outdated Show resolved Hide resolved

charlesrocket force-pushed the dwl branch 5 times, most recently from 51955ce to 4c7ebfc Compare March 8, 2026 12:03

wayland: add dwl/mango support

a89f16b

charlesrocket force-pushed the dwl branch from 4c7ebfc to a89f16b Compare March 8, 2026 17:04

charlesrocket requested a review from outfoxxed March 8, 2026 17:04

outfoxxed requested changes Mar 8, 2026

View reviewed changes

		/// Whether a client is fullscreen on this output.
		Q_PROPERTY(bool fullscreen READ fullscreen NOTIFY fullscreenChanged);

		/// Whether the focused client is floating.
		Q_PROPERTY(bool floating READ floating NOTIFY floatingChanged);

Conversation

charlesrocket commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

outfoxxed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charlesrocket commented Mar 8, 2026

Uh oh!

outfoxxed commented Mar 8, 2026

Uh oh!

charlesrocket commented Mar 8, 2026

Uh oh!

outfoxxed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

outfoxxed Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

outfoxxed Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

outfoxxed Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

outfoxxed Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

outfoxxed commented Mar 8, 2026

Uh oh!

charlesrocket commented Mar 9, 2026

Uh oh!

charlesrocket commented Mar 9, 2026

Uh oh!

herry6548 commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charlesrocket commented Mar 6, 2026 •

edited

Loading

herry6548 commented Mar 9, 2026 •

edited

Loading