Skip to content

Conversation

@PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Jan 10, 2022

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

When querying, Quickwit needs to make multiple GET requests:

```jsx
#num requests = #num splits * ((#num search fields * #num terms * 3) + #num fast fields)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not put fast field number as today I think we are only getting the timestamp fast field values, right? So I would put only 1.

Copy link
Collaborator Author

@PSeitz PSeitz Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, timestamp and sort_by, but sort_by is deacticated


/// Extracts all fast field names.
fn extract_fast_field_names(doc_mapper: &dyn DocMapper) -> HashSet<String> {
    let mut fast_fields = HashSet::new();
    if let Some(timestamp_field) = doc_mapper.timestamp_field_name() {
        fast_fields.insert(timestamp_field);
    }
    if let SortBy::FastField { field_name, .. } = doc_mapper.sort_by() {
        fast_fields.insert(field_name);
    }
    fast_fields
}

@fmassot fmassot merged commit 5f84994 into quickwit-oss:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants