Search and indexing can run together, and do so as a default Issue/1160#1163
Merged
fulmicoton merged 1 commit intomainfrom Mar 28, 2022
Merged
Search and indexing can run together, and do so as a default Issue/1160#1163fulmicoton merged 1 commit intomainfrom
fulmicoton merged 1 commit intomainfrom
Conversation
fulmicoton
force-pushed
the
issue/1160
branch
4 times, most recently
from
ab3063c to
f139638
Compare
fulmicoton
changed the title
fmassot
reviewed
Mar 11, 2022
fmassot
reviewed
Mar 11, 2022
fmassot
reviewed
Mar 11, 2022
fmassot
reviewed
Mar 11, 2022
fmassot
approved these changes
Mar 11, 2022
Collaborator
fmassot
left a comment
fmassot
left a comment
There was a problem hiding this comment.
I think you nailed it with this require. It will work well with new services.
Can you check why the formatting of proto auto-generated files changed?
fmassot
reviewed
Mar 13, 2022
fulmicoton
force-pushed
the
issue/1160
branch
11 times, most recently
from
4a13992 to
1832a9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to run indexing and search together.
They are now "services"...
The gRPC and the rest server are always running and make all running services available.
In order to make it possible, we will be temporarily relying on a specific unpublished rev of tonic,
to benefit from the following PR.
TLDR the generic in tonic's router have been removed very recently.
In other words, the type of a gRPC does not depend on the subset of service that are being mounted.
hyperium/tonic#830
Closes #1160