add support for exist in query language#3800
Merged
trinity-1686a merged 3 commits intomainfrom Sep 20, 2023
Merged
Conversation
trinity-1686a
force-pushed
the
trinity--exists-query-syntax
branch
from
94d197f to
f3d97f3
Compare
fulmicoton
approved these changes
Sep 19, 2023
trinity-1686a
force-pushed
the
trinity--exists-query-syntax
branch
from
f3d97f3 to
81e9536
Compare
Contributor
Author
|
it seems recent tantivy wants more memory for some arena. I increased a value in some place and tests now passes, but I'm suspicious of whether this other place needs changes too. @PSeitz would you know that by any chance? |
Collaborator
Yes, |
this seems required by some recent change in tantivy
trinity-1686a
force-pushed
the
trinity--exists-query-syntax
branch
from
3d7f39a to
99753f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #3714
How was this PR tested?
tested manually
Could probably use some tests