use correct precision level for fastfield-based termquery on datetime#6027
Merged
trinity-1686a merged 1 commit intomainfrom Dec 18, 2025
Merged
use correct precision level for fastfield-based termquery on datetime#6027trinity-1686a merged 1 commit intomainfrom
trinity-1686a merged 1 commit intomainfrom
Conversation
fulmicoton-dd
approved these changes
Dec 18, 2025
nico34638
pushed a commit
to nico34638/quickwit
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when querying indexed timestamps, we truncate dates to the second, as that's how they are stored inside the index, however when querying a non-indexed, fast field, we still do that truncation. This result in queries not matching when they should (or matching when they shouldn't if a doc has a timestamp with no sub-second value, but the query has a sub-second value). This PR make it so when we're about to run a datetime termquery over fastfield, we search for a value with the precision of the fastfield, and not the precision of an sstable
How was this PR tested?
added unit test