Merged
Conversation
guilload
reviewed
Dec 22, 2025
quickwit/quickwit-metastore/migrations/postgresql/25_add-split-size.up.sql
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Outdated
Show resolved
Hide resolved
Abdul-Andha
changed the title
guilload
reviewed
Dec 26, 2025
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Show resolved
Hide resolved
| } | ||
| _ => None, | ||
| }) | ||
| .map(|index_id| (index_id.clone(), None)) |
Member
There was a problem hiding this comment.
Why bother with the None? Let's just pass None directly to read_any and make everything else simpler.
| let mut index_stats = Vec::new(); | ||
| for (index_id, incarnation_id_opt) in index_id_incarnation_id_opts { | ||
| match self | ||
| .read_any(&index_id, incarnation_id_opt, |index| index.get_stats()) |
Member
There was a problem hiding this comment.
Behind the hood, this is going to open each metastore file and then fetch the split stats sequentially, which is going to be slow if there are many indexes. Try to parallelize this logic using FuturesUnordered. There are examples in the file.
guilload
approved these changes
Dec 29, 2025
nico34638
pushed a commit
to nico34638/quickwit
that referenced
this pull request
Jan 5, 2026
* add list_index_size_info endpoint and migration 25 * add filtering, change endpoint name, nits * add breakdown by split state * lints * lints * test_get_stats and nits * use futuresunordered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
split_size_bytescolumn insplitstable and create covered indexHow was this PR tested?