Skip to content

Fix rustfmt compatibility with nightly 1.96#6187

Merged
Platane merged 1 commit intoquickwit-oss:mainfrom
Platane:fix-rustfmt-nightly
Mar 2, 2026
Merged

Fix rustfmt compatibility with nightly 1.96#6187
Platane merged 1 commit intoquickwit-oss:mainfrom
Platane:fix-rustfmt-nightly

Conversation

@Platane
Copy link
Collaborator

@Platane Platane commented Mar 2, 2026

Summary

  • Rustfmt 1.9.0 (shipped in nightly 2026-03-01) changed behavior for imports_granularity = "Module": top-level imports are no longer merged (changelog)
  • Since the project uses imports_granularity = "Module" in rustfmt.toml, grouped re-exports like pub use {bytes, tonic}; are now expanded into individual statements
  • CI uses unpinned toolchain: nightly for rustfmt, so any PR touching Rust files will fail Lints until this is fixed
  • Two files affected: quickwit-common/src/rate_limited_tracing.rs and quickwit-proto/src/lib.rs

Test plan

  • CI Lints job passes with nightly rustfmt

🤖 Generated with Claude Code

Rustfmt 1.9.0 (shipped in nightly 2026-03-01) changed behavior for
`imports_granularity = "Module"`: top-level imports are no longer
merged. Expand grouped `pub use` re-exports and fix sort order.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Platane Platane force-pushed the fix-rustfmt-nightly branch from 234943f to ca0b9a5 Compare March 2, 2026 14:25
@Platane Platane marked this pull request as ready for review March 2, 2026 14:27
@Platane Platane enabled auto-merge (squash) March 2, 2026 14:38
@Platane Platane merged commit 1b9d419 into quickwit-oss:main Mar 2, 2026
4 checks passed
rdettai-sk pushed a commit to SekoiaLab/quickwit that referenced this pull request Mar 2, 2026
Rustfmt 1.9.0 (shipped in nightly 2026-03-01) changed behavior for
`imports_granularity = "Module"`: top-level imports are no longer
merged. Expand grouped `pub use` re-exports and fix sort order.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants