Skip to content

compute timeseries_id for sketches#6348

Merged
mattmkim merged 4 commits intomainfrom
matthew.kim/byoc-fix-sketches-ingestion
Apr 27, 2026
Merged

compute timeseries_id for sketches#6348
mattmkim merged 4 commits intomainfrom
matthew.kim/byoc-fix-sketches-ingestion

Conversation

@mattmkim
Copy link
Copy Markdown
Contributor

Description

Compute timeseries_id for sketches.

How was this PR tested?

Describe how you tested this PR.

@mattmkim mattmkim marked this pull request as ready for review April 27, 2026 18:27
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd8fae524f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quickwit/quickwit-parquet-engine/src/ingest/arrow_sketches.rs Outdated
Copy link
Copy Markdown
Contributor

@g-talbot g-talbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fix the codex comment.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f9518316d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quickwit/quickwit-parquet-engine/src/ingest/arrow_sketches.rs
@mattmkim mattmkim merged commit 10d109e into main Apr 27, 2026
9 checks passed
@mattmkim mattmkim deleted the matthew.kim/byoc-fix-sketches-ingestion branch April 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants