Dont schedule indexing tasks on retiring indexers#6427
Open
ncoiffier-celonis wants to merge 3 commits into
Open
Dont schedule indexing tasks on retiring indexers#6427ncoiffier-celonis wants to merge 3 commits into
ncoiffier-celonis wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix #6413
This PR tracks the ingester status in the control plane indexer pools, and avoid to schedule indexing tasks on retiring indexers.
Special case: for a single node indexer (for example most of the integration tests), we still need to schedule indexing tasks on retiring indexers, otherwise the shards are never "drained", and the decomission process times out without publishing the splits.
Todo:
How was this PR tested?
Not tested