fix(cli): correct merge command description#6438
Open
singhvishalkr wants to merge 1 commit into
Open
Conversation
The previous description suggested that the command merges all splits into one, but it actually runs available merge operations according to the merge policy. Closes quickwit-oss#3805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description says the merge command 'Merges all the splits' which is misleading since it doesn't actually merge everything into a single split.
Looking at the implementation, the command spawns a merge pipeline that runs available merge operations according to the configured merge policy, then exits when there are no more ongoing merges.
Updated the description to reflect this behavior.
Closes #3805