Revert to using existing merge flow when standalone compactors isnt explicitly enabled#6453
Merged
Merged
Conversation
nadav-govari
commented
May 20, 2026
nadav-govari
merged commit efaba73
into
nadav/feature-split-merges
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It would be hard to maintain two parallel performance profiles of standalone compactors running on their own nodes, but then also on indexer nodes - performance profiles, balancing resource usage, etc. for two standalone services that need to share. The existing merge pipelines on indexing pipelines is proven and works, and additionally, all existing workflows are on this pattern; it'll also be easier to revert into this mode if there are problems with standalone compactors.
For that reason, standalone compactors will be explicitly on opt in to start with, as an experimental feature. A pod will only start if the compactor service is explicitly enabled (its not in default services), and if the flag is on. It will bail otherwise.
This restores the existing merge pipelines in indexing code. If the compactors flag is on, it doesnt spawn the merge components, assuming that work is fully delegated to compactors.
How was this PR tested?
Local pipeline, unit tests, and restored old deleted tests.