Make standalone compactors config top-level#6471
Merged
nadav-govari merged 3 commits intoMay 31, 2026
Merged
Conversation
| /// Standalone compactors means that indexer nodes don't run merges. | ||
| /// This flag affects the behavior of the compactor service, the indexer service, | ||
| /// and the janitor service (the planner lives there). If this flag is enabled and the | ||
| /// compactor service is enabled on this node, it'll error. The janitor and indexer will |
Contributor
There was a problem hiding this comment.
The janitor and indexer will?
Collaborator
Author
There was a problem hiding this comment.
I think im just removing this comment. No need to put whole documentation inline.
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_indexer_implicitly_runs_compactor() { |
Contributor
There was a problem hiding this comment.
why is that test being removed?
Collaborator
Author
There was a problem hiding this comment.
Originally, we were going to force standalone compactors to be false (meaning indexers still had to do merges). To still get merges, we were going to have indexer nodes run both the indexer and compactor service. We decided since then to not go that route, and indexers should no longer implicitly run the compactor service as a result.
nadav-govari
merged commit a5b1b01
into
nadav/merge-feature-split-merges
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the standalone compactors config node-level, which makes more sense than in the indexing configs, since its used by three different services: janitor, indexer, compactor.
How was this PR tested?
Unit tests and fixed other tests.