Skip to content

test(storage): cover GCS HTTPS OpenDAL TLS regression#6482

Open
palkakrzysiek wants to merge 2 commits into
quickwit-oss:mainfrom
palkakrzysiek:codex/fix-gcs-opendal-tls
Open

test(storage): cover GCS HTTPS OpenDAL TLS regression#6482
palkakrzysiek wants to merge 2 commits into
quickwit-oss:mainfrom
palkakrzysiek:codex/fix-gcs-opendal-tls

Conversation

@palkakrzysiek
Copy link
Copy Markdown

Follow-up to #6478. This keeps regression coverage for the OpenDAL GCS TLS feature by exercising Quickwit's OpendalStorage get_slice path against a local HTTPS GCS-like endpoint with TLS verification enabled.

Replaces #6479, which GitHub closed automatically after the temporary fix/gcs-opendal-tls base branch was deleted.

Local verification on commit 5de97a1:

  • cargo check --features=postgres --tests --bin quickwit
  • cargo check --features=postgres,metrics --tests --bin quickwit
  • cargo nextest run --features=postgres,metrics --retries 1
  • REST API tests against target/debug/quickwit
  • cargo clippy --workspace --tests --all-features
  • cargo deny check licenses
  • cargo machete
  • scripts/check_license_headers.sh
  • cargo fmt --all -- --check
  • git diff --check
  • dd-rust-license-tool check
  • cargo doc --no-deps
  • cargo test -p quickwit-datafusion --tests
  • cargo test -p quickwit-integration-tests --features datafusion metrics_distributed_tests -- --test-threads=1

@palkakrzysiek palkakrzysiek marked this pull request as ready for review June 1, 2026 22:36
@palkakrzysiek palkakrzysiek requested review from a team as code owners June 1, 2026 22:36
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5de97a18f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +26 to +27
-not_before 20200101000000Z \
-not_after 30200101000000Z \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use supported OpenSSL validity options

When the documented regeneration script is run with OpenSSL 3.0.13, it exits before emitting any certificates because openssl req -help lists -days for generated certificate validity but does not accept -not_before/-not_after here; the redirected stderr makes the failure silent except for the nonzero exit. The same unsupported flags are used again for the server certificate below, so anyone trying to refresh the embedded test certs cannot reproduce them with the checked-in script.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it compatible with OpenSSL 3.0.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant