test(storage): cover GCS HTTPS OpenDAL TLS regression#6482
test(storage): cover GCS HTTPS OpenDAL TLS regression#6482palkakrzysiek wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5de97a18f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| -not_before 20200101000000Z \ | ||
| -not_after 30200101000000Z \ |
There was a problem hiding this comment.
Use supported OpenSSL validity options
When the documented regeneration script is run with OpenSSL 3.0.13, it exits before emitting any certificates because openssl req -help lists -days for generated certificate validity but does not accept -not_before/-not_after here; the redirected stderr makes the failure silent except for the nonzero exit. The same unsupported flags are used again for the server certificate below, so anyone trying to refresh the embedded test certs cannot reproduce them with the checked-in script.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
made it compatible with OpenSSL 3.0.13
Follow-up to #6478. This keeps regression coverage for the OpenDAL GCS TLS feature by exercising Quickwit's OpendalStorage get_slice path against a local HTTPS GCS-like endpoint with TLS verification enabled.
Replaces #6479, which GitHub closed automatically after the temporary fix/gcs-opendal-tls base branch was deleted.
Local verification on commit 5de97a1: