nits from ARTART review #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitema
approved these changes
Dec 23, 2025
Contributor
huitema
left a comment
huitema
left a comment
There was a problem hiding this comment.
The proposed fixes look good, indeed improve the document!
Yanmei-Liu
approved these changes
Dec 23, 2025
Contributor
|
I have verified that the fixes proposed here will also sole the nits listed in the Gen Art review (issue #627) |
kazuho
reviewed
Dec 28, 2025
Revert the spurious attempt to use acknowledgements
Contributor
Author
|
It's not my language, so I don't care, but I do want it to be consistent. main has 21 occurrences of the word, 6 of which use acknowledgment and 15 of which use acknowledgement. The PR changes the minority (and follows RFC 7322 in that). Of course, the authors can agree to change all 21 to acknowledgment. Changing back just one doesn't make sense, so I changed the other 20 ones as well. |
This was referenced Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.