fix(updater): timestamp on errors and footer in chat mode#147
Merged
quiet-node merged 5 commits intomainfrom May 7, 2026
Merged
fix(updater): timestamp on errors and footer in chat mode#147quiet-node merged 5 commits intomainfrom
quiet-node merged 5 commits intomainfrom
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…iant Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related bugs in the auto-updater surface:
"Last checked: Never" persists across failed checks. When the manifest fetch errors (network issue, 4xx/5xx, GitHub
latest/download/URL temporarily 404'ing during a publish window), the poller logs the error but does not record that an attempt was made. The user sees "Never" forever even after multiple checks. Fix: record a timestamp on every check, even when it fails.Chat-footer update indicator never renders in chat mode. The
UpdateFooterBarwas placed inside an existing{!isChatMode && ...}gate alongside theTipBar, accidentally inheriting the same scope restriction. Per design, the update strip should be visible in both ask-bar and chat modes (an update is signal worth showing mid-conversation; a tip is not). Fix: hoist the update branch above the mode gate so it always renders when an update is available; tips remain ask-bar only.Changes
Backend (
src-tauri/src/updater/)UpdaterState::mark_check_attempted()updateslast_check_atwithout touching the cachedupdate. Preserves any previously known available version so a flaky network does not erase real signal.poller::check_oncecallsmark_check_attemptedon both error paths (updater builder failure, manifest check failure).Frontend (
src/App.tsx)showUpdateis true, renderUpdateFooterBarregardless of mode; otherwise fall back to the existing ask-bar-onlyTipBarbranch.keeps the UpdateFooterBar visible after entering chat modemounts the App, simulates entering chat mode, and asserts the update bar still renders. This pins down the bug we just fixed so it cannot regress.Test plan
bun run test:all:coverageclean (1233 frontend + 755 Rust tests, 100% line and function coverage)bun run validate-buildclean (no signing key required locally)Last checked X seconds agoshows after a failed check, notNever