fix(settings): user-configurable typography controls for chat and input#172
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…quick keystroke Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…ng field Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…ching config Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…graphy controls Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…tive labels Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…rns, and coverage gaps Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[window]in config.toml:text_base_px,text_line_height,text_letter_spacing_px, andtext_font_weight--thuki-text-base,--thuki-text-line-height,--thuki-text-letter-spacing,--thuki-text-font-weight) from the resolved config via a new useEffect in App.tsxpatch_documentwhere whole-number JSON saves into missing float fields were persisted as TOML Integer instead of Float, causing the next fractional save to fail with a type mismatch; schema-derived template is now the authoritative type sourceArchitecture
Follows the documented config checklist exactly: defaults in
config/defaults.rs, schema inschema.rs, validation/clamping inloader.rs, frontend projection inConfigContext, and full test coverage at every layer.Test plan
bun run test:all:coverage- all 1295 frontend tests + 858 backend tests pass, both coverage gates greenbun run validate-build- lint, format, typecheck, and production build all clean