feat(updater): What's New update window with explicit actions; open Settings on current Space#174
Merged
Merged
Conversation
…ur actions Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…cot, and tokenized styling Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…er fullscreen apps Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…ors, correct stale panel docs Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated "What's New" update window and routes every update entry point (chat footer, Settings banner, tray menu) through it so the user previews release notes and picks an action explicitly instead of an install starting on a single click. Also fixes the Settings panel to open on the user's current macOS Space (including over another app's fullscreen Space) instead of stranding it on Space 1.
Changes
src/view/update/UpdateWindow.tsx,src/main.tsx,src/hooks/useUpdater.ts): editorial release-notes layout with four actions: Skip This Version, Remind Me Later, Install & Quit, Install & Restart. Markdown body + publish date from the updater manifest, GitHub-link fallback when notes are absent.src-tauri/src/updater/*,lib.rs):skip_update_version/open_update_windowcommands, persistedskipped_versions(back-compatible sidecar),should_surface_updatedecision helper,ThukiUpdatePanelNSPanel modeled on the overlay panel.lib.rs): settings/update panels use the proven overlay pattern (nonactivating+can_join_all_spaces, noactivateIgnoringOtherApps) so they appear in-place on the current Space.Review hardening (commit 50ed8d7)
core:window:allow-closecapability (least-privilege: no frontend path callswindow.close(); close is intercepted Rust-side and windows onlyhide()).UpdateWindowaction handlers no longer silently swallow promise rejections: a sharedrunActionhelper logs the failure and still closes the window so it cannot hang with no feedback.is_floating_panel,show_*_windowactivation notes,install_update_innertray rationale).Testing
bun run test:all:coverage: 1314 frontend tests pass; backend llvm-cov 100% lines/functions/branches.bun run validate-build: clean (lint + clippy + format + typecheck + full build), zero warnings/errors.🤖 Generated with Claude Code