fix: sync Cargo.lock on release PRs via release workflow#43
Merged
quiet-node merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Release-please bumps Cargo.toml via extra-files but cannot safely update Cargo.lock (many unrelated packages share the same semver, so a naive string replace would corrupt them). This adds a dedicated workflow that triggers on release-please PRs, runs 'cargo update --package thuki', and commits the updated Cargo.lock back to the PR branch so the release commit is complete. Also syncs Cargo.lock to 0.2.1 to clear the unstaged diff left by the last release. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
force-pushed
the
worktree-structured-floating-stearns
branch
from
e5c7ed7 to
f9436f9
Compare
quiet-node
changed the title
quiet-node
changed the title
This was referenced Apr 6, 2026
quiet-node
added a commit
that referenced
this pull request
Apr 6, 2026
Removes the sync-cargo-lock job and the pr output added in PRs #43-#52. The release-please action started failing with 'Resource not accessible by integration' and the sync job is the only change to this workflow in that window. Reverting to the original two-job workflow to restore stability. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
fix: sync Cargo.lock and add workflow to keep it in sync on release PRs Release-please bumps Cargo.toml via extra-files but cannot safely update Cargo.lock (many unrelated packages share the same semver, so a naive string replace would corrupt them). This adds a dedicated workflow that triggers on release-please PRs, runs 'cargo update --package thuki', and commits the updated Cargo.lock back to the PR branch so the release commit is complete. Also syncs Cargo.lock to 0.2.1 to clear the unstaged diff left by the last release. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
fix: sync Cargo.lock and add workflow to keep it in sync on release PRs Release-please bumps Cargo.toml via extra-files but cannot safely update Cargo.lock (many unrelated packages share the same semver, so a naive string replace would corrupt them). This adds a dedicated workflow that triggers on release-please PRs, runs 'cargo update --package thuki', and commits the updated Cargo.lock back to the PR branch so the release commit is complete. Also syncs Cargo.lock to 0.2.1 to clear the unstaged diff left by the last release. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 11, 2026
fix: sync Cargo.lock and add workflow to keep it in sync on release PRs Release-please bumps Cargo.toml via extra-files but cannot safely update Cargo.lock (many unrelated packages share the same semver, so a naive string replace would corrupt them). This adds a dedicated workflow that triggers on release-please PRs, runs 'cargo update --package thuki', and commits the updated Cargo.lock back to the PR branch so the release commit is complete. Also syncs Cargo.lock to 0.2.1 to clear the unstaged diff left by the last release. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
release-please bumps `Cargo.toml` via `extra-files`, but cannot safely update `Cargo.lock`. Using the `generic` extra-file type would do a naive string replace of `0.2.0` across the whole file, corrupting 9 unrelated packages that share that semver. So `Cargo.lock` was always left stale after each release merge (happened at 0.2.0, then again at 0.2.1).
How the fix works
A second job in `release-please.yml` that:
Test plan
🤖 Generated with Claude Code