Skip to content

Ensure that preview, thumbnail lambdas handle Glacier-style 403s#1789

Merged
akarve merged 3 commits intomasterfrom
storage-class
Sep 8, 2020
Merged

Ensure that preview, thumbnail lambdas handle Glacier-style 403s#1789
akarve merged 3 commits intomasterfrom
storage-class

Conversation

@akarve
Copy link
Member

@akarve akarve commented Sep 8, 2020

No description provided.

@akarve akarve requested a review from kevinemoore September 8, 2020 00:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #1789 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
+ Coverage   88.00%   88.07%   +0.07%     
==========================================
  Files          62       62              
  Lines        6884     6904      +20     
==========================================
+ Hits         6058     6081      +23     
+ Misses        826      823       -3     
Flag Coverage Δ
#api-python 85.68% <ø> (ø)
#lambda 92.16% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lambdas/thumbnail/index.py 79.56% <ø> (+1.45%) ⬆️
lambdas/preview/index.py 98.14% <100.00%> (+0.92%) ⬆️
lambdas/preview/test/test_index.py 99.69% <100.00%> (+<0.01%) ⬆️
lambdas/thumbnail/tests/test_thumbnail.py 94.54% <100.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0335462...5299c34. Read the comment docs.

@akarve akarve changed the title Ensure that preview, thumbnail labmdas handle Glacier-style 403s Ensure that preview, thumbnail lambdas handle Glacier-style 403s Sep 8, 2020
@akarve akarve merged commit 287b737 into master Sep 8, 2020
@akarve akarve deleted the storage-class branch September 8, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants