Merged
Conversation
Member
Author
|
@kevinemoore did you mean smth like this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4488 +/- ##
========================================
Coverage 37.90% 37.90%
========================================
Files 826 826
Lines 36460 36460
Branches 5972 5972
========================================
Hits 13819 13819
- Misses 21413 22120 +707
+ Partials 1228 521 -707
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
sir-sigurd
approved these changes
Aug 26, 2025
kevinemoore
approved these changes
Aug 26, 2025
Contributor
kevinemoore
left a comment
There was a problem hiding this comment.
Looks good. It's a big help to include a link to the ES schemas from the python search API docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the documentation for the
searchmethod in both the Python API and the user documentation. It adds direct links to the Quilt Search documentation, making it easier for users to find information about index schemas and search examples.Documentation improvements:
searchmethod inapi/python/quilt3/api.pyandapi/python/quilt3/bucket.py.docs/api-reference/Bucket.mdanddocs/api-reference/api.mdto include a link to the Quilt Search documentation for further guidance on search queries.