lambdas: do not install test deps in .zip package#4659
Merged
sir-sigurd merged 3 commits intomasterfrom Dec 8, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4659 +/- ##
==========================================
+ Coverage 36.71% 40.58% +3.86%
==========================================
Files 865 899 +34
Lines 35433 37882 +2449
Branches 6238 6238
==========================================
+ Hits 13009 15374 +2365
- Misses 21153 21237 +84
Partials 1271 1271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
This reverts commit 41c8afa.
Member
Author
drernie
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Excluded test dependencies from lambda deployment packages by adding
--no-default-groupsflag to uv export commands.default-groups = ["test"]which was causing test deps to be included by defaultConfidence Score: 5/5
--no-default-groupsflag is the proper uv command for excluding default dependency groups. Both CI and production build scripts are updated consistently.Important Files Changed
File Analysis
--no-default-groupsflag to requirements export to exclude test dependencies from production builds, matching the build_zip.sh change--no-default-groupsflag to prevent test dependencies from being included in lambda deployment packagesSequence Diagram
sequenceDiagram participant GH as GitHub Actions participant UV as uv (package manager) participant Build as build_zip.sh participant Lambda as Lambda Package Note over GH,Lambda: CI Test Flow (.github/workflows/py-ci.yml) GH->>UV: uv export --no-default-groups<br/>(production deps only) UV-->>GH: requirements.txt GH->>UV: uv export --only-group test UV-->>GH: test-requirements.txt GH->>GH: Install production deps to deps/ GH->>GH: Install test deps separately GH->>GH: Run pytest with both sets Note over Build,Lambda: Production Build Flow (build_zip.sh) Build->>UV: uv export --no-default-groups<br/>(production deps only) UV-->>Build: requirements.txt Build->>Build: uv pip install --target . Build->>Build: Compile, strip, cleanup Build->>Lambda: Create deployment .zip<br/>(no test deps)