ui.actions.deleteObject for quilt config editor#4692
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4692 +/- ##
=======================================
Coverage 43.23% 43.23%
=======================================
Files 799 799
Lines 32020 32020
Branches 5708 5708
=======================================
Hits 13844 13844
Misses 16182 16182
Partials 1994 1994
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nl0
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
ui.actions.deleteObjectconfiguration option to the Quilt config editor, allowing administrators to control visibility of delete buttons for files and directories in the bucket interfaceImportant Files Changed
catalog/app/utils/BucketPreferences/BucketPreferences.tsdeleteObjectto ActionPreferences type and default preferences with valuefalsecatalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/State.tsxui.actions.deleteObjectparsing and validation into bucket preferences state managementcatalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/BucketPreferences.tsxdeleteObjectaction with proper internationalization textConfidence score: 5/5
Sequence Diagram
sequenceDiagram participant User participant Component as "BucketPreferences" participant Parser as "parse" participant Handler as "onChange" participant Validator as "validate" participant Stringifier as "stringify" User->>Component: "Modify configuration field" Component->>Handler: "handleChange(value)" Handler->>Component: "setConfig(updated config)" Component->>Stringifier: "stringify(config)" Stringifier->>Validator: "validate(aux)" Validator-->>Stringifier: "validation result" Stringifier-->>Component: "YAML string" Component->>Handler: "onChange(YAML string)"