Skip to content

ui.actions.deleteObject for quilt config editor#4692

Merged
fiskus merged 6 commits intomasterfrom
delete-object-quilt-config-editor
Jan 14, 2026
Merged

ui.actions.deleteObject for quilt config editor#4692
fiskus merged 6 commits intomasterfrom
delete-object-quilt-config-editor

Conversation

@fiskus
Copy link
Copy Markdown
Member

@fiskus fiskus commented Jan 14, 2026

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Greptile Summary

  • Adds ui.actions.deleteObject configuration option to the Quilt config editor, allowing administrators to control visibility of delete buttons for files and directories in the bucket interface
  • Updates the bucket preferences system with proper parsing, validation, testing, and UI integration for the new configuration option
  • Includes comprehensive test coverage and documentation following established patterns for UI action configurations

Important Files Changed

Filename Overview
catalog/app/utils/BucketPreferences/BucketPreferences.ts Adds deleteObject to ActionPreferences type and default preferences with value false
catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/State.tsx Integrates ui.actions.deleteObject parsing and validation into bucket preferences state management
catalog/app/components/FileEditor/QuiltConfigEditor/BucketPreferences/BucketPreferences.tsx Adds UI configuration field for deleteObject action with proper internationalization text

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it follows established patterns and includes comprehensive testing
  • Score reflects thorough implementation with proper type safety, testing coverage, and consistent integration across the configuration system
  • No files require special attention as all changes are straightforward additions following existing conventions

Sequence Diagram

sequenceDiagram
    participant User
    participant Component as "BucketPreferences"
    participant Parser as "parse"
    participant Handler as "onChange"
    participant Validator as "validate"
    participant Stringifier as "stringify"
    
    User->>Component: "Modify configuration field"
    Component->>Handler: "handleChange(value)"
    Handler->>Component: "setConfig(updated config)"
    Component->>Stringifier: "stringify(config)"
    Stringifier->>Validator: "validate(aux)"
    Validator-->>Stringifier: "validation result"
    Stringifier-->>Component: "YAML string"
    Component->>Handler: "onChange(YAML string)"
Loading

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.23%. Comparing base (c5bd6ba) to head (4577bfd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4692   +/-   ##
=======================================
  Coverage   43.23%   43.23%           
=======================================
  Files         799      799           
  Lines       32020    32020           
  Branches     5708     5708           
=======================================
  Hits        13844    13844           
  Misses      16182    16182           
  Partials     1994     1994           
Flag Coverage Δ
api-python 91.96% <ø> (ø)
catalog 19.43% <100.00%> (ø)
lambda 96.63% <ø> (ø)
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiskus fiskus marked this pull request as ready for review January 14, 2026 15:16
@fiskus fiskus enabled auto-merge January 14, 2026 15:51
@fiskus fiskus requested a review from nl0 January 14, 2026 15:51
@fiskus fiskus added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit f221aeb Jan 14, 2026
46 checks passed
@fiskus fiskus deleted the delete-object-quilt-config-editor branch January 14, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants