Skip to content

docs: prefer Route 53 alias records, keep CNAME as fallback#4879

Merged
drernie merged 5 commits into
masterfrom
docs-dns-records-consistency
May 7, 2026
Merged

docs: prefer Route 53 alias records, keep CNAME as fallback#4879
drernie merged 5 commits into
masterfrom
docs-dns-records-consistency

Conversation

@drernie
Copy link
Copy Markdown
Member

@drernie drernie commented May 4, 2026

Summary

Aligns the catalog installation DNS guidance with the Quilt Connect Server docs and the new CFN-output policy in deployment#2408: CFN output descriptions stay generic about record type; the docs are explicit.

Customer-driven: DNS record-type guidance

Prompted by a customer (Walter Gillett) noticing that we tell people to create CNAMEs while the Connect docs (correctly) recommend Route 53 alias records. Aliases are strictly better when the hosted zone is in Route 53 (no per-query charges, zone-apex support); CNAME is the right answer when DNS is hosted elsewhere.

  • docs/Catalog/Installation.md:240: rename section "CNAMEs" → "DNS records", recommend Route 53 alias (with LoadBalancerCanonicalHostedZoneID as the alias hosted zone), present CNAME as the fallback for non-Route-53 DNS.
    • Backward-compat: explicit <a id="cnames"></a> anchor preserved so existing cross-doc links to #cnames still resolve.
  • docs/Catalog/Installation.md:64: prerequisites bullet broadened from "CNAME records" to "Route 53 alias records or CNAMEs".
  • Updated the in-doc [CNAMEs](#cnames) link to [DNS records](#dns-records).

Opportunistic: pre-existing broken links

Noticed while auditing the DNS guidance — these were already broken on master, unrelated to the policy change but cheap to fix here.

  • docs/Troubleshooting.md:63: SSO link pointed to technical-reference.md#cnames (no such anchor); retargeted to technical-reference.md#single-sign-on-sso.
  • docs/Troubleshooting.md:67: "CNAMEs" link pointed to the same nonexistent anchor; retargeted to Catalog/Installation.md#dns-records.

Test plan

  • Render the page locally — section renders as "DNS records"
  • Existing #cnames deep links still scroll to the section
  • Troubleshooting links resolve to the right anchors

🤖 Generated with Claude Code

Bring the catalog DNS guidance in line with the Connect Server docs:
recommend Route 53 alias records for customers whose hosted zone is in
Route 53 (free queries, zone-apex support), and present CNAMEs as the
fallback for non-Route-53 DNS.

Renames the "CNAMEs" section to "DNS records" but preserves the
existing #cnames anchor for backward compatibility with cross-doc
links.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.51%. Comparing base (f9290bc) to head (c24452e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4879   +/-   ##
=======================================
  Coverage   46.51%   46.51%           
=======================================
  Files         832      832           
  Lines       34116    34116           
  Branches     5828     5828           
=======================================
  Hits        15868    15868           
  Misses      16243    16243           
  Partials     2005     2005           
Flag Coverage Δ
api-python 93.14% <ø> (ø)
catalog 21.48% <ø> (ø)
lambda 96.63% <ø> (ø)
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

drernie and others added 2 commits May 4, 2026 16:53
The Troubleshooting "Unable to log in" links pointed to
technical-reference.md#cnames, an anchor that does not exist in that
file. The CNAME content lives in Catalog/Installation.md.

- SSO link: drop the dead #cnames fragment (technical-reference.md
  covers SSO at the file level).
- DNS link: retarget to Catalog/Installation.md#dns-records.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Point the "SSO connector misconfigured" link at the
"Single sign-on (SSO)" heading in technical-reference.md instead of
the file root.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Quilt Catalog installation documentation to recommend Route 53 alias records (with CNAME as a fallback for non–Route 53 DNS) and fixes pre-existing broken troubleshooting links related to SSO and DNS guidance.

Changes:

  • Update Catalog installation DNS guidance: rename “CNAMEs” section to “DNS records”, recommend Route 53 alias records, and keep CNAME instructions as fallback (while preserving the legacy #cnames anchor).
  • Broaden the installation prerequisite to include Route 53 alias records or CNAMEs.
  • Fix broken links in Troubleshooting to point to the correct SSO anchor and the updated DNS section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/Catalog/Installation.md Reworks DNS setup section to prefer Route 53 alias records, retains CNAME fallback, updates prerequisite wording, and updates internal link target.
docs/Troubleshooting.md Fixes broken links for SSO reference and DNS-related guidance, updates wording from “CNAMEs” to “hostnames”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/Catalog/Installation.md Outdated
Comment thread docs/Catalog/Installation.md Outdated
drernie and others added 2 commits May 5, 2026 10:16
- Drop stray "Key" column text and fix <RegistryHostName> -> <RegistryHost>
  to match the actual CFN output names.
- Replace overly broad "no per-query DNS charges" claim with the accurate
  AWS wording (free for alias queries to AWS resources like ALBs).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@drernie drernie requested a review from kevinemoore May 6, 2026 16:38
@drernie drernie enabled auto-merge May 6, 2026 17:05
@drernie drernie added this pull request to the merge queue May 7, 2026
Merged via the queue into master with commit 3b1afdb May 7, 2026
46 checks passed
@drernie drernie deleted the docs-dns-records-consistency branch May 7, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants