Skip to content

Fix tests#68

Merged
drernie merged 15 commits intomainfrom
fix-tests
Dec 13, 2024
Merged

Fix tests#68
drernie merged 15 commits intomainfrom
fix-tests

Conversation

@drernie
Copy link
Copy Markdown
Member

@drernie drernie commented Dec 10, 2024

  • Add convenience methods
  • Fix failing CI tests

@drernie
Copy link
Copy Markdown
Member Author

drernie commented Dec 12, 2024

org.opentest4j.AssertionFailedError: expected: 97ea1254aab77d28e0f459a739351879b46e6e6142efdab327abf6ab6bdf72dd but was: e329b376d98083054be18881f3471fff7957acdfca8b02c54946f082dc56b572

Hash seems to always include workflow (even if null). The versionId is changed, so that might cause the error:

{"version":"v0","message":null,"workflow":{"id":null,"config":"s3://quilt-dima2/.quilt/workflows/config.yml?versionId=ASUPIhu6w_z1WIYlC8cnybaxP1jBrS_L"}}

Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowConfig.java Outdated
Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowConfig.java Outdated
Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowConfig.java Outdated
Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowConfig.java Outdated
Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowValidator.java Outdated
Comment thread lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowValidator.java Outdated
drernie and others added 5 commits December 12, 2024 16:13
- always create well-formed system metadata
- use filename for logical key (to test BuildFromDir)
@drernie drernie merged commit c5c89be into main Dec 13, 2024
@drernie drernie deleted the fix-tests branch December 13, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant