Rebase to master gregcockroft and fix cdep dependency#2
Merged
Conversation
for now, directly call the function on the mainActivity. next step would be updating the mathDisplayLib to somehow handle the bitmap creation process
to convert latex string to a bitmap
fix things to be able to run ./gradlew mathdisplaylib:build error was: uses-sdk:minSdkVersion 16 cannot be smaller than version 19 declared in library [:mathdisplaylib:]
fix the font null exception when calling createBitmap()
also: - make the MTFontManager as object, exposing it's setContext() - remove dependency to context on MTMathGenerator
to make it simple if we want to change color font from the main project
also: - increase minSDK to 21
andremw96
changed the title
leo0263
approved these changes
Mar 30, 2023
leo0263
left a comment
leo0263
left a comment
There was a problem hiding this comment.
LGTM 👀 👍
thanks for fixing the cdep problem 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.