Skip to content

Refactor Dockerfile#509

Merged
int128 merged 2 commits intomainfrom
int128/Refactor-Dockerfile
Sep 3, 2024
Merged

Refactor Dockerfile#509
int128 merged 2 commits intomainfrom
int128/Refactor-Dockerfile

Conversation

@int128
Copy link
Member

@int128 int128 commented Sep 3, 2024

  • Revise comments
  • Fix the warnings of docker/build-push-action

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

🆕 If you need to build a new runner image, create a new release after merge.

# some setup actions store cache into /opt/hostedtoolcache
ENV RUNNER_TOOL_CACHE /opt/hostedtoolcache
# Some setup actions store cache into /opt/hostedtoolcache
ENV RUNNER_TOOL_CACHE=/opt/hostedtoolcache
Copy link
Member Author

@int128 int128 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the warning of docker/build-push-action

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

🆕 If you need to build a new runner image, create a new release after merge.

@int128 int128 marked this pull request as ready for review September 3, 2024 06:33
@int128 int128 requested a review from a team as a code owner September 3, 2024 06:33
@int128 int128 requested a review from aoi1 September 3, 2024 06:34

# DO NOT ADD ANY PACKAGE!
# We'd like to keep this image small for long-term maintanability and security.
# If you want to install a package, use https://aquaproj.github.io in your workflow.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: 追加例へのリンクがあるとより親切そうです

@int128 int128 merged commit f8dc40a into main Sep 3, 2024
@int128 int128 deleted the int128/Refactor-Dockerfile branch September 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants