Add a way to change coverage report path#95
Merged
kof merged 6 commits intoqunitjs:masterfrom Jul 24, 2014
Merged
Conversation
Contributor
Author
|
@kof What do you think? |
Contributor
|
Looks good, one thing: lets change path to {path: ...} in .setup |
Contributor
|
Wait better "dir" to be consistent with istanbul. |
Contributor
Author
|
@kof something along this line? |
Contributor
There was a problem hiding this comment.
you don't need the assignment :)
Contributor
Author
There was a problem hiding this comment.
That is what I thought, but this is slightly less magic right?
Contributor
Author
There was a problem hiding this comment.
I mean bit more readable.
Contributor
There was a problem hiding this comment.
works both for me ... anyways, wanna change?
Contributor
Author
|
sure, np :) |
kof
added a commit
that referenced
this pull request
Jul 24, 2014
Add a way to change coverage report path
Contributor
|
merged |
Contributor
|
published |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.