Tests: Fix script src for stack-errors test#1003
Conversation
We need a way to automate discovering the files to run in our test suite. Currently there is too much manual intervention (you have to update the Gruntfile every time a name changes or a file is added), which I believe is why this was missed for so long. Looking at the tests though, were these ever passable? I don't see anything to negate the expected failures. I'm also not sure these test anything not covered by our other tests. |
|
I think the purpose of that suite was to manually check if stack traces are reported properly. But since it was broken for quite a while, I guess no one was doing that. It would be nice to have some automated tests in the regular test suite, then we could delete this one. |
Yes, and while we don't have it improved, I applied this fix. merged at b2338e9 |
Fixed the bad reference, but the test still seems pretty broken.
globalstest reports "Introduced global variable(s): external, chrome, document, test, module, expect, start, ok, notOk, equal, notEqual, propEqual, notPropEqual, deepEqual, notDeepEqual, strictEqual, notStrictEqual, throws, raises, QUnit, polluteGlobal, speechSynthesis, caches, ondeviceorientationabsolute, localStorage, sessionStorage, webkitStorageInfo, indexedDB, webkitIndexedDB, ondeviceorientation, ondevicemotion, crypto, postMessage, blur, focus, [...]" and many more.And apparently the whole test suite isn't run as party of
npm test, so the very basic issue of a bad file reference went unnoticed until now. As such, maybe the better solution is to delete it?