Docs: Fix broken QUnit.stop link from assert/async and add redirect#1291
Merged
Docs: Fix broken QUnit.stop link from assert/async and add redirect#1291
Conversation
Proof of concept for #1289. * Fix broken link to /QUnit/stop which no longer exists. * For incoming links from elsewhere, set up a redirect from there to the closest currently related page, which is /assert/async. The redirect logic uses the Jekyll Redirect From plugin, which is also allowed and preinstalled on GitHub Pages. For local dev, add the same name and version of that gem, per <https://pages.github.com/versions/>.
platinumazure
approved these changes
Jun 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for #1289.
to the closest currently related page, which is /assert/async.
The redirect logic uses the Jekyll Redirect From plugin, which
is also allowed and preinstalled on GitHub Pages. For local dev,
add the same name and version of that gem, per
https://pages.github.com/versions/.