Skip to content

Comments

Component: Assert.push#994

Closed
rdugue wants to merge 1 commit intoqunitjs:masterfrom
rdugue:890-deprecate-assert.push
Closed

Component: Assert.push#994
rdugue wants to merge 1 commit intoqunitjs:masterfrom
rdugue:890-deprecate-assert.push

Conversation

@rdugue
Copy link
Contributor

@rdugue rdugue commented May 6, 2016

This prints a message to the console stating that this function is now
deprecated, and pushResult is preferred.

Fixes #986

This prints a message to the console stating that this function is now
deprecated, and pushResult is preferred.

Fixes qunitjs#890
} );

QUnit.test("push", function( assert ) {
assert.push( null );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this demonstrate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just shows that warning prints really.

@trentmwillis
Copy link
Member

Thanks for the initiative @rdugue! However, our current plan is to wait until our new warnings API has landed (see #918) and reuse the original PR I had made to close the issue (see #992).

@rdugue
Copy link
Contributor Author

rdugue commented May 6, 2016

Wooops, should have read further. I'll go ahead and close this then.

@rdugue rdugue closed this May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants