uri2fsn: fix handling of relative paths with newer Python#17
Merged
lazka merged 2 commits intoquodlibet:mainfrom Nov 26, 2024
Merged
uri2fsn: fix handling of relative paths with newer Python#17lazka merged 2 commits intoquodlibet:mainfrom
lazka merged 2 commits intoquodlibet:mainfrom
Conversation
Python 3.12 changed urlunparse() results for relative file uris as a side effect of some other changes. It's not clear what and why from the git history, so try to reproduce the new behaviour for all Python versions (if path doesn't start with / then strip them from the result). And since urlunparse() is no longer guaranteed to return uris starting // move the netloc hack up to simplify things. tbh I'm a bit out of the loop re URIs, so I hope on the test coverage to prevent any oversights. Fixes quodlibet#16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 changed urlunparse() results for relative file uris as a side
effect of some other changes. It's not clear what and why from the
git history, so try to reproduce the new behaviour for all Python
versions (if path doesn't start with / then strip them from the result).
And since urlunparse() is no longer guaranteed to return uris starting
// move the netloc hack up to simplify things.
tbh I'm a bit out of the loop re URIs, so I hope on the test coverage
to prevent any oversights.
Fixes #16