Skip to content

feat: adding color theme mode setting#928

Merged
ACTCD merged 3 commits intomainfrom
theme-setting
May 10, 2026
Merged

feat: adding color theme mode setting#928
ACTCD merged 3 commits intomainfrom
theme-setting

Conversation

@ACTCD
Copy link
Copy Markdown
Collaborator

@ACTCD ACTCD commented May 10, 2026

@ACTCD ACTCD merged commit 8b743e3 into main May 10, 2026
1 check passed
@ACTCD ACTCD deleted the theme-setting branch May 10, 2026 01:09
@ACTCD
Copy link
Copy Markdown
Collaborator Author

ACTCD commented May 10, 2026

It does not take effect on the iOS settings page. Will solve it in the future.

@ACTCD
Copy link
Copy Markdown
Collaborator Author

ACTCD commented May 10, 2026

There are some upstream bugs that are known to exist in different system versions, for example:

  • Click any extension button and Safari will ignore the color-scheme css of the Editor page, until reload.
  • Safari may ignore popup's child element color-scheme override, the specific mechanism is unknown.

These should not be considered implementation issues for this extension and can only wait for upstream fixes.

@ACTCD
Copy link
Copy Markdown
Collaborator Author

ACTCD commented May 10, 2026

Since the current settings changes are persisted async and do not await for completion, if the user closes the page too quickly, the settings may not be persisted, although this is usually not happens.

But later refactoring should probably add indicators and await for persistence to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant