[QUO-2017] Polling for detections, cleanup artificats, readme, lint #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddiev4
reviewed
May 15, 2025
examples/example_logs.ts
Outdated
| console.log('pollForDetectionResults with logId: ', logId); | ||
|
|
||
| // poll for the detection results | ||
| const detectionResults = await quotientLogger.pollForDetectionResults(logId); |
Member
There was a problem hiding this comment.
Shouldn't this be pollForDetection?
Member
There was a problem hiding this comment.
examples/example_logs.ts
Outdated
| @@ -1,49 +1,63 @@ | |||
| import { QuotientAI } from '../quotientai'; | |||
Member
There was a problem hiding this comment.
Think this should be from quotientai?
freddiev4
reviewed
May 15, 2025
README.md
Outdated
|
|
||
| ```typescript | ||
| new QuotientAI(apiKey?: string) | ||
| QUOTIENT_API_KEY={{YOUR_API_KEY}} ts-node examples/example_logs.ts |
Member
There was a problem hiding this comment.
I would actually just copy and paste example_logs.ts directly in here rather than have it be in the repo. Assume people won't clone this but instead have only done npm install quotientai
QUOTIENT_API_KEY={{YOUR_API_KEY}} ts-node example.ts
Contributor
Author
There was a problem hiding this comment.
Ok I did this. This makes a lot of sense!
freddiev4
previously approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.