Add icons to single measurement table#1791
Merged
petebankhead merged 1 commit intoqupath:mainfrom Mar 10, 2025
Merged
Conversation
The purpose is to: * Make classifications stand out more (with color) * Make it possible to distinguish measurements from the measurement list, from those calculated dynamically * Provide a visual queue to distinguish between annotations, detections & TMA cores The last of these is done by using the same icons used for show/hide in the toolbar. The hope is that this helps reinforce the association between object type and icon. Note that the implementation is a bit messy because we don't currently have a way to query the type of a measurement from `ObservableMeasurementTableData`. If/when this is refactored to reduce any JavaFX dependency, we should try to improve this; currently, it's not entirely robust, because someone *could* add measurements or metadata values with duplicate names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose is to:
The last of these is done by using the same icons used for show/hide in the toolbar. The hope is that this helps reinforce the association between object type and icon - and that cells/tiles are really subtypes of detection (because the icon is the same).
Note that the implementation is a bit messy because we don't currently have a way to query the type of a measurement from
ObservableMeasurementTableData- so we rely on the names (keys). If/when this is refactored to reduce any JavaFX dependency, we should try to improve this; currently, it's not entirely robust, because someone could add measurements or metadata values with duplicate names. But I think that's an acceptable risk for now, because it would already be problematic when working with measurements, and it's not expected to occur in normal use.